SystemSan: detect argument injection vulnerabilities#10767
Closed
swapgs wants to merge 2 commits intogoogle:masterfrom
swapgs:systemsan-detect-argument-injection
Closed
SystemSan: detect argument injection vulnerabilities#10767swapgs wants to merge 2 commits intogoogle:masterfrom swapgs:systemsan-detect-argument-injection
swapgs wants to merge 2 commits intogoogle:masterfrom
swapgs:systemsan-detect-argument-injection
Conversation
Author
|
cc @oliverchang @alan32liu, I think this PR could benefit from your reviews :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows SystemSan to detect argument injection bugs. It adds a new value in the fuzzing dictionary,
--tripwire, and reports an issue only if one ofexecve()'sargv[]starts by this value. There's also support for the POSIX end-of-options switch to reduce false positives.Please look at PRs #10593, #10724, and eventually #9407 before this one–if they get merged I'll have things to update to here. Next step on my roadmap will be to add a proper PoE for this feature.